- Issue created by @tbadaczewski
niharika.s β changed the visibility of the branch 3501829- to hidden.
Are people actively maintaining this project? I don't mean maintainer open to PRs, but actually responding to issues?
This is a very important module for our web application, and not having it compatible with Drupal 11 is holding us back from upgrading.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
@tbadaczewski hey I'm still here but I wear a lot of hats
My advice would be to look to move away from Gatsby in general - the health of the Drupal project isn't the issue - the health of the Javascript project is - e.g. see https://github.com/gatsbyjs/gatsby/issues/38696Drupal 10 is supported until mid/late 2026 so there's not as much urgency to get a D11 version out.
We have moved all our Drupal+Gatsby projects to something that isn't Gatsby so don't have any client projects where this update is pressing.
What this means is I'm happy to review MRs if things are ready but I'm unlikely to have time to dedicate to authoring them.
larowlan thanks for the strait talk info, I do appreciate it. We have been looking to shift from GatsbyJS to NextJS, but we were hoping to upgrade the Drupal 10 backend to Drupal 11 first. I'm hoping that this module already supports Drupal 11, but just needs a version bump in the info file. I'll do my own testing to see what problems arise. Once again, thanks for the response.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
No worries, happy to merge stuff to unblock.
I created a patch that solves the only PHP errors I had when testing this module with a Drupal 11 on a PHP 8.4 install. I also was able to install this on my current Drupal 10.4 update without any issues.
It also updates the core versions to ^11.
I'd love some feedback.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
@tbadaczewski nothing in that patch looks out of place to me, would committing this to HEAD make things easier?
Sorry, this is my first time submitting a patch so not sure next steps. Did you want me to commit the updated code to the 2.0.x branch directly?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
No sorry mate, I'm asking if I should commit this for you - would that make further improvements easier?
I'm not working on the module but I don't want to block fine folks like yourself who are - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
The patch doesn't apply to 8.x-1.x - needs a reroll
That was my fault, I always intended this issue to be in the context of the 2.0.0-rc2 version. I updated the issue to reflect that.
Could you try again?
This patch has been updated to also address the "drupal/upgrade_status" scan module finding of a depreciated function call.
Call to deprecated method loadRevision() of interface Drupal\Core\Entity\EntityStorageInterface. Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
-
larowlan β
committed 438c1c84 on 2.0.x
Issue #3501829 by tbadaczewski: Drupal 11 Support
-
larowlan β
committed 438c1c84 on 2.0.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks I've committed and pushed that change to the 2.0.x branch
Added two addtional PHP modifications so that the entire codebase adhears to the "NullableTypeForNullDefaultValue" standard. Without these changes you would get "Deprecated" warnings when running on PHP 8.4.X.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Can you provide just the new changes? I can't apply the current patch - thanks
Here is a patch that just has the additional changes for:
- Deprecated loadRevision() Storage Type
- Nullable Type For Null Default Value PHP 8.4 Warning
FYI, I've since upgrade my production site last week to Drupal 11 and this module is working great with these patches applied!