- Issue created by @SteffenR
- 🇩🇪Germany SteffenR Germany
Unfortunately it is not possible to fix the CI problem without putting views_bulk_operations in the root composer.json of the module.
Within a submodule the dependency is not recognized by the default workflow.That's why i will close the issue and build a separate project containing the functionality.
- 🇷🇴Romania amateescu
I think this should be part of the main module, can't see why it would require a sub-module to be enabled. As for putting requirements in the main
composer.json
file just for Gitlab CI, a "soft" dependency can be put into therequire-dev
section :) - 🇩🇪Germany SteffenR Germany
@amateescu: thx for you comment. I hadn't thought of this possibility at the time. That makes sense.
- 🇷🇴Romania amateescu
Looked a bit into this and the problem with VBO is that its altering views queries twice, see https://git.drupalcode.org/project/views_bulk_operations/-/blob/4.3.x/sr...
Implemented a simple fix for that, and added support for its confirmation form inside the existing form alter.
@steffenr, can you check the new MR and see if it covers everything properly?
-
amateescu →
committed 98629434 on 3.x
Issue #3501163 by steffenr: Add support for (contrib) Views Bulk...
-
amateescu →
committed 98629434 on 3.x
- 🇷🇴Romania amateescu
Merged MR !47 into 3.x, thanks for reporting and working on this!
- 🇷🇴Romania amateescu
@steffenr, note that the MR that was merged did not create a submodule, it fixed everything in the main module :)
- 🇩🇪Germany SteffenR Germany
@amateescu: Ah i see.
Thx for integrating the changes directly into the module. Just had a closer look at the changes you made ;).. Automatically closed - issue fixed for 2 weeks with no activity.