Move SDC specific validation in ValidComponentTreeConstraintValidator::validate into the SDC source plugin

Will continue this later.

The tricky bit is that:

• the stored explicit input (e.g. a JSON-encoded StaticPropSource for an SDC prop) is not the same as the resolved explicit input (e.g. the URL or integer or whatever that that StaticPropSource resolves to).
• validateComponentInput() as implemented for SDC in HEAD is about validating the stored explicit input, not the resolved!

Fixed in https://git.drupalcode.org/project/experience_builder/-/merge_requests/5... — but we'll need to think this through more, because having two validation methods in each component source is going to be confusing. I'd like to end up with a single one.

I expect still lots of failures, because lots still needs to happen. But at least there's a start now.

Managed to leave it in a clearer, better place. More tomorrow.

Was on a call with @effulgentsia and discussed two points with him

1. Remove \Drupal\experience_builder\Plugin\DataType\ComponentPropsValues::getPropSourceTypePrefixList as it should be internal to the SDC source plugin - I think we should hold off on this until we see how javascript components look. Wim, Dave and I already had a discussion about evaluated vs non-evaluated input and there may be a concept that evolves that isn't SDC specific. I'll open a separate issue as Alex agreed we should leave it for the time being. Removed it from the IS
2. Should we separate 'clientModelToInput' and 'validateClientInput' so that the former doesn't do any validation at all, but the later is called immediately after. Alex agreed as this is consistent with how EntityForm works in core - I'll continue with that

📌 [PP-2] Consider moving ComponentPropsValues::getPropSourceTypePrefixList into source plugins Active for #10.1

WHAT A WAY TO START MY DAY! 😊 🤓 🥳

I read all commits in order and found myself nodding the entire time! 😄

The incoherent unfinished bits I had locally were all finished in the same way by @larowlan.

Blissful start of this Thursday! 😁

I reviewed this very thoroughly and found a few minor problems, but most importantly was able to make ValidComponentTreeConstraintValidator truly ComponentSource-agnostic! 🥳

Ideal next issue: 📌 Remove references to 'props' outside of SDC - use 'inputs' instead Active .

#10.2++ — but I think that can happen in a follow-up. Everything in here already is highly valuable and fixed several critical data integrity bugs! (It also makes that subsequent issue much smaller.) Tagging for just that bit.

(Merged given that @larowlan independently pushed this forward in the exact same direction I was going. No need to delay this crucial data integrity/validation/clean-up issue!)

@longwave posted 2 remarks minutes after merging — thankfully he opened 📌 Decouple component UUID from clientModelToInput and validateComponentInput Active to address those excellent observations! 😊

Automatically closed - issue fixed for 2 weeks with no activity.