- Issue created by @dabley
- First commit to issue fork.
- Merge request !3Issue #3500946: Fix for foreach() null argument. → (Merged) created by Unnamed author
- 🇺🇸United States mradcliffe USA
I think rather than do that, we can just change getEnabledPlugins to always return an array rather than be nullable.
This seems to be covering up the problem rather than solving it. It looks to me as if there ought to always be at least one processor.
By default the "Posts to Xero" processor is toggled on (and cannot be toggled off) - so the "Posts to Xero" processor ought to be always shown in the list - shouldn't it?
If I enable the "Invoice lookup" toggle, then the list of Processors is updated to show "Posts to Xero" and also "Invoice lookup". When I then disable the "Invoice lookup" toggle, the list of Processors is updated to show "Posts to Xero" on its own. So why doesn't the "Posts to Xero" processor appear in the list of processors at the outset?
- 🇺🇸United States mradcliffe USA
Testing locally and writing a test reveals that the plugins are listed appropriately on a new install and Posts to Xero is checked by default.
The warning still needed to be fixed though.
-
mradcliffe →
committed 2c571c3e on 2.0.x authored by
priti197 →
Issue #3500946 by mradcliffe, priti197, dabley: Error when attempting to...
-
mradcliffe →
committed 2c571c3e on 2.0.x authored by
priti197 →
Thanks for fixing. The patch works for me.
I think my earlier message wasn't clear. "Post to Xero" is shown in the list of processors, and is toggled on. But "Post to Xero" does not initially appear in the "Processor Order" list. It only appears in the Processor Order list after another processor has been selected. I guess this doesn't matter, since when only 1 processor is selected, is isn't necessary to specify the ordering.
Automatically closed - issue fixed for 2 weeks with no activity.