PHPUnit failure

Testing phpunit locally:

I get lots of "deprecation" messages, which do not show up in the GitLab pipeline.

I do get one "PHP deprecation" message too, which does show up.

• In CustomElementsRenderMarkupTest and ...Vue3Test

• 3 tests triggered 1 PHP deprecation:
  1) /builds/project/custom_elements/web/core/lib/Drupal/Core/Config/Entity/Query/Condition.php:39
  mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated
  Triggered by:
  * Drupal\Tests\custom_elements\Functional\CustomElementsRenderMarkupTest::testNodeRendering (3 times)

I've ignored this until now, because I thought it was a Core thing.

Some googling got me to #3302838-18: Querying with NULL values results in warning mb_strtolower(): Passing null to parameter is deprecated → and then also #30 which references 🐛 'filter.format.' . WebformHtmlEditor::DEFAULT_FILTER_FORMAT missing UUID Fixed == a contrib fix commit.

We should probably do something similar, and the error (absence of a UUID for a config entity?) is probably somewhere in importPartialThunderConfig().

roderik → changed the visibility of the branch 3500903-phpunit-failure to hidden.

roderik → changed the visibility of the branch 3500903-phpunit-failure to active.

Confirmed: apparently it is specifically the "PHP deprecation" that caused Gitlab to report failure.

Fixing it makes phpunit report "orange" in Gitlab (for all the other deprecation messages reported by code in e.g. paragraphs module), and the full job report "green".

The fix was exactly the same as in the referenced webform issue: import config entities through entity API, not "plain" config API. (Apparently then they get UUIDs and there is no "NULL" condition in a query.) I just needed to modernize some code before applying the fix on top of it.

Automatically closed - issue fixed for 2 weeks with no activity.