- Issue created by @Fabianx
- ð©ðªGermany Fabianx
Note: There is a bug right now, where views_ui is not correctly replacing the placeholders.
This is due to the check for the Sql object, which is now a SelectInterface object.
This MR fixes this as a side effect, but this means this is lacking test coverage.
- ð¬ð§United Kingdom catch
One minor nit on the MR otherwise this looks great! Hopefully there's an existing test that almost tests this which we can extend.
- First commit to issue fork.
- ð³ð±Netherlands Lendude Amsterdam
Added minimal test coverage, about the same as what we have for the other data that is rendered in the preview. Since different databases output very different explain data it seems, actually checking the output might be too much here since we might need to switch by database type, which I don't think we want to do, sounds fragile and excessive.
On SQLite this seems to output quite a lot of data, do we want to add a toggle for adding 'explain' data, like we have for the other data?