BatchOperations::assembleRows blindly calls getTotalItemCount

Created on 15 January 2025, 3 months ago

Problem/Motivation

When BatchOperations::assembleRows is called to build the List of BatchOperations in the UI it blindly calls $script->getTotalItemCount(); which gathers the items to be processed (could be an intensive gathering)
but then in buildCompleteStatus() it only uses that value if there is no BatchOpLog from a previous run.

There are two options

  1. Remove this early call and only call if needed.
  2. Keep the early call, but do something with the value, like identify if the last run shows a completion number that does not match the currently count.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States swirt Florida

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024