- Issue created by @balintbrews
- 🇳🇱Netherlands balintbrews Amsterdam, NL
In case ✨ [PP-1] Editing code components as overrides, step 1 Postponed lands sooner, we need to make sure that code components that are overrides can't be added to the components.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Consult how this change needs to be represented in the code component's config entity
The way this was implemented in ✨ Config entity for storing code components Active + ✨ Create a ComponentSource plugin for JS components Active :
- The "code component" (
JavaScriptComponent
config entity) has itsstatus
set totrue
. - This causes
\Drupal\experience_builder\EntityHandlers\JavascriptComponentStorage::doPostSave()
to create the correspondingComponent
config entity.
This is already implemented and tested on the back end.
So the UI shown in the issue summary should only need to
PATCH
the config entity (using the/xb/api/config/js_component/…
) and setstatus
totrue
. - The "code component" (
- Merge request !699#3500071: Adding code components to components → (Merged) created by Unnamed author
-
balintbrews →
committed a039993a on 0.x
Issue #3500071 by balintbrews, wim leers: Adding code components to...
-
balintbrews →
committed a039993a on 0.x
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
To make this actually have the effect we intend it to have, we need to fix the back end: 🐛 JavaScriptComponent's `status` must be respected by the Active .