Fix composer job to allow cspell and phpstan to run

As a first attempt I have moved the line into after_script and added composer update. This might be correct, but I don't know enough about how the Sodium extension to verify it.

But this change has had the intended result that phpstan and phpcs run and pass green, and cpsell is actually running instead of crashing at the start.
Compare this new pipeline https://git.drupalcode.org/issue/openid_connect_windows_aad-3499969/-/pi...
with the previous latest one https://git.drupalcode.org/project/openid_connect_windows_aad/-/pipeline...

There was a custom 'show-environment-variables' which is identical to the gitlab templates version except that it exposes the users personal email and other PID. Is there a specific reason why you can't use the version provided by gitlab. I have added _SHOW_ENVIRONMENT_VARIABLES: 1 so that these are displayed in each of the composer jobs.

Also I have removed

SKIP_STYLELINT: 1
SKIP_ESLINT: 1

There is no need to skip stylelint because the project has no .css files, so the job is never added (that fix was implemented in gitlab templates maybe after you added this variable)

The project does not have any .js files, but eslint does check the validity of all *.yml so it is worth having this job enabled. By default .yml are all ignored for 'prettier' formatting, so you will not be getting warning about that. This was also a later fix in gitlab templates. The job passes green.

Update title and I.S.

The changes LGTM
PHPCS, CSPELL and PHPSTAN are now running and not crashing at start
Moving to RTBC+

Excellent, thank you. As the custom .show-environment-variables is no longer used or required I will remove that from the file.

Cool, Since it isn't required, it can be removed! go ahead!

Done.

I have also replaced $_TARGET_PHP with $PHP_VERSION in the single line in the after_script. The reason is that $_TARGET_PHP is the same for all variants but $PHP_VERSION varies and is derived correctly for the variant being run. If you decided that you did need this step for the 'max php' variant then you will now have the correct max php value.

Great

The deprecated $_TARGET_PHP has been replaced with $PHP_VERSION
unrequired .show-environment-variables has been removed
PHPCS, CSPELL and PHPSTAN are now running and not crashing at start

All pipelines are passing except cspell, for which an issue 📌 Make code pass cspell Active has already been created.

The status is already RTBC, i dont think we need to change that! This MR can be merged!
Thanks!

Thanks for the help with this one.

Automatically closed - issue fixed for 2 weeks with no activity.