- Issue created by @dydave
- Merge request !4Issue #3499850 by DYdave: Added module configuration schema file. β (Merged) created by dydave
- π«π·France dydave
Added initial module schema file in merge request MR!4 above at #2.
The config type
path
used for the routes fields, is inspired from Drupal core system.schema.yml for the 403 and 404 pages path fields, defined on the basic site settings form, see:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...
without any specific validation constraints or rules.See the result with config_inspector:
Details:
Any reviews and feedback would be greatly appreciated.
Thanks in advance! -
drupalmatts β
committed 156dc1ac on 8.x-dev authored by
dydave β
Issue #3499850 by DYdave: Added module configuration schema file.
-
drupalmatts β
committed 156dc1ac on 8.x-dev authored by
dydave β
- π«π·France dydave
Thanks a lot Matthew (@drupalmatts) for getting the changes merged above at #4, it's greatly appreciated!
Thanks also for creating the login_switch-3.x-dev β development release.
However, I'm not completely clear about the version naming of the branches:
The 3.x branch looks pretty outdated, going back to 2022, see:
https://git.drupalcode.org/project/login_switch/-/commits/3.x?ref_type=h...and you've merged the changes above in the 8.x-dev branch:
https://git.drupalcode.org/project/login_switch/-/commits/8.x-dev?ref_ty...which seems to be the current development branch.
What's the plan with the different branches?
Could we maybe remerge 8.x-dev into 3.x and move developments into 3.x?This would simplify the understanding of module's code base and be more consistent with the stable version names, for example 3.0.3:
https://www.drupal.org/project/login_switch/releases/3.0.3 βFor the time being, I'll try creating MRs for the 8.x-dev branch.
Otherwise, not sure if you had anything else in mind with this issue but perhaps you could credit both of us and mark it fixed for now?
So we could move to fixing other tickets.In any case, thanks again for your great help keeping the module maintained.
Cheers! - Status changed to Fixed
27 days ago 5:28pm 26 March 2025 Automatically closed - issue fixed for 2 weeks with no activity.