Contrib.social

Temporary fork supporting latest versions of dependencies

Open on Drupal.org →
Created on 14 January 2025, 3 months ago

Problem/Motivation

There are many patches needed to support the latest versions of the H5P dependencies, and some of the patches have conflicts that need manual resolution. The pace of commits to this module is slow.

Proposed resolution

As a temporary way to help me install a working copy of the H5P module that works on PHP 8.3 and uses the latest version of dependencies I've created a fork at https://github.com/ShaunDychko/h5p on the branch 2.0.x-patched where the commit messages document which patches have been applied and have links to the d.o issues, or patches with issue numbers in their links. This might be useful for other site builders/developers wanting to get set up quickly without navigating the many open issues. To use this, for add to your composer.json

 "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/ShaunDychko/h5p"
    },

And then run composer require drupal/h5p:dev-2.0.x-patched.

Remaining tasks

Wait for some of the critical patches to get applied, namely 💬 Support h5p/h5p-core 1.27 and h5p/h5p-editor 1.25 in H5PDrupal.php Active , 📌 Remove vendor directory and composer.lock from project repository Active , and 🐛 Support a11y_title from h5p-core 1.27 Needs review , and then delete this fork.

🌱 Plan
Status

Active

Version

2.0

Component

Documentation

Created by

🇨🇦Canada shaundychko

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @shaundychko
  • Comment 3 months ago →
    🇨🇦Canada shaundychko
  • Comment 2 months ago →
    🇺🇸United States NicholasS

    Adding the "exclude" for "drupal/h5p" to your code example.

  • Comment 2 months ago →
    🇺🇸United States NicholasS

    I had to combine with a Drush update composer require drupal/h5p:dev-2.0.x-patched drush/drush:^13 -W

    But I can confirm this updates h5p so its compatible with PHP 8.3

  • Comment about 2 months ago →
    🇺🇸United States chamilsanjeewa

    I followed the steps and used the forked branch, but I still encountered the errors below.

    Also, @shaundychko, do you plan to merge this into the module?

  • Comment about 2 months ago →
    🇨🇦Canada shaundychko

    @chamilsanjeewa thank you for trying out the fork. I don't have commit access to this module so I can't merge into it. The intention is to keep the fork only while waiting for the maintainers to commit the patches to the module, and then I would delete the fork. The error messages you posted are related to downloading the H5P libraries since your site is searching for files in the ./default/files/h5p directory.

  • Comment about 2 months ago →
    🇺🇸United States chamilsanjeewa

    Hi Shaundychko,

    Thank you. Unfortunately, we can't grant write access to the server. We need to move everything using Composer and pipelines instead.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024