- Issue created by @budalokko
- Merge request !404Issue #3499702: Explain the the documentation that AI CKEditor requires the Source CKEditor button. → (Merged) created by budalokko
- 🇪🇸Spain budalokko Girona
MR 404 contains the third option:
- Just mention in the documentation.
- 🇩🇪Germany marcus_johansson
Thank you for finding this bug and the MR for the documentation change. We will make sure as well that this gets validated before merging.
- Merge request !413Ensure the sourceEditing plugin is always abvailable for the Completion AI... → (Merged) created by MrDaleSmith
- 🇬🇧United Kingdom MrDaleSmith
I've gone a different way in https://git.drupalcode.org/project/ai/-/merge_requests/413 - if we need the sourceEditing plugin for the javascript to work, we should make sure its added to the field that needs it. That way, no-one needs to have a plugin they don't want enabled just because of the way this is coded.
- 🇪🇸Spain budalokko Girona
Your solution works like a charm !! Tested in both situations:
- The original text format already contained
sourceEditing
plugin -> still works - The original text format does not contain
sourceEditing
plugin -> now it works !!
So this would be RTBC for me.
- The original text format already contained
- 🇩🇪Germany marcus_johansson
Nice solution Paul - I will trust budalokko for the funcitonal review, both MR are getting merged. Thanks both.
-
marcus_johansson →
committed 8ecb7f3b on 1.0.x authored by
budalokko →
Issue #3499702: Explain the the documentation that AI CKEditor requires...
-
marcus_johansson →
committed 8ecb7f3b on 1.0.x authored by
budalokko →
- 🇬🇧United Kingdom MrDaleSmith
@marcus_johansson I don't think it makes sense to merge both, does it? The first MR adds help text that says you have to enable the Source Editing plugin, and the second makes it so you don't have to enable the Source Editing plugin. Won't the documentation be confusingly wrong now?
- 🇬🇧United Kingdom MrDaleSmith
Raised https://www.drupal.org/project/ai/issues/3501661 📌 Documentation incorrect for AI CKEditor Active to resolve.
Automatically closed - issue fixed for 2 weeks with no activity.