- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
There was 1 error: 1) Drupal\Tests\experience_builder\Unit\OpenApiSpecValidationTest::testSpecIsValid Exception: Could not find OpenAPI 3.0 schema at /builds/project/experience_builder/vendor/devizzent/cebe-php-openapi/schemas/openapi-v3.1.json. /builds/project/experience_builder/tests/src/Unit/OpenApiSpecValidationTest.php:51 /builds/project/experience_builder/vendor/bin/phpunit:122 ERRORS!
https://git.drupalcode.org/project/experience_builder/-/jobs/4012600#L557
🆚
Remove not needed files from the package.
🫣
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Yep, https://github.com/DEVizzent/cebe-php-openapi/commit/2612cf7702f27900a1f... added
/schemas
to.gitignore
and is the last commit included in the1.1.3
tag. 🙃The commit message indicates this is intentional. So perhaps we should not have been relying on the presence of https://github.com/DEVizzent/cebe-php-openapi/blob/master/schemas/openap... in the Composer-installed package — but instead we should download
https://spec.openapis.org/oas/3.1/schema/2021-09-28
?I think it's safer then to essentially take the same approach they did: commit a downloaded version of https://spec.openapis.org/oas/3.1/schema/2021-09-28 and add it to our
.gitignore
. Because whilejustinrainbow/json-schema
is required,league/openapi-psr7-validator
is optional for XB, as isdevizzent/cebe-php-openapi
.As you can see in the docs for
\Drupal\experience_builder\EventSubscriber\ApiMessageValidatorBase::$validatorBuilder
, XB's OpenAPI request/response validator infrastructure does run only if those last 2 packages are installed. - Merge request !538Resolve #3499602 "Ci devizzentcebe php openapi 1.1.3" → (Merged) created by wim leers
-
wim leers →
committed 5b1584c9 on 0.x
Issue #3499602 by wim leers: CI: DEVizzent/cebe-php-openapi 1.1.3 broke...
-
wim leers →
committed 5b1584c9 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.