Attempt to read property "sms" on array MigrateTfaUserSettings.php:98

Hi @jibus, Thanks for reporting the issue.

I observed that notice only for one of my records that are being migrated which doesn't have sms plugin value and for other records it migrated with out notice.

Are you seeing it for multiple records ?

Can you ping me on Drupal slack @bhanu951, we can discuss it over there.

I believe we should add empty variable $decoded_data check at this line.

Can you add that check and confirm if it fixes the notice.

https://git.drupalcode.org/project/tfa_migration/-/blob/1.x/src/Plugin/m...

$data_sms = (isset($decoded_data->sms)) ? boolval($decoded_data->sms) : FALSE;

fix the warning "[warning] Attempt to read property "sms" on array MigrateTfaUserSettings.php:98"

    // If the user has TFA enabled, convert the enabled plugins from their
    // Drupal 7 names and values to their Drupal 9 names and values.
    if (isset($decoded_data->plugins)) {

fix the warning : "[warning] Attempt to read property "plugins" on array MigrateTfaUserSettings.php:104"

@jibus : I made code changes to fix the warning.

Can you apply the patch - 3499387-MR12 and check if the issue is resolved.

Thank you, patch #7 fix the warning.

Automatically closed - issue fixed for 2 weeks with no activity.