Interface should show below Gin toolbar

Indeed. The tip dialogs do need to paint over the interface, but the tip marks don't necessarily. Playing with Gin Toolbar, it looks like setting the z-index param to precisely 491 might give what you are looking for on the frontend:

...that does run some risks, as absolutely positioned elements could end up with marks being hidden entirely behind Gin. But that is rare, and you could still get to those marks via the "next tip" button on the panel.

But on the backend...the backend is so much more complicated. Here we have frequent situations where the marks partially intersect the Gin components (to get them off the text someone is editing), and at certain breakpoints CKEditor floats the interface. Using 491 (so the two elements are 501 and 502) can make it so CKEditor draws on top of Editoria11y dialogs, which is no good:

...and unfortunately Gin's left and top bars are set to 501 and 502, so there's no number between them I can use.

In an earlier branch I had separate settings depending on whether CKEditor was present on the page. This is easy, as they are all inheriting a CSS variable that can be changed at will. I could go back to that, so the overdraw would only happen when there was a CKEditor frame under the toolbar -- the marks hide when scrolled out of the visible part of the CKEditor frame.

Otherwise -- I think I would need Gin (and Drupal core) to change so that the vertical sidebar and the top toolbar had a z-index value available between the two -- 501 and 503 rather than 501 and 502. But I'd be surprised if people were willing to make that big a change. It would help me and possible other modules though...

Should be fixed in 2.2.1

Marking fixed for now. Please reopen if you notice issues.

Automatically closed - issue fixed for 2 weeks with no activity.

I'm using Editoria11y v2.2.7, Gin Admin Theme 3.x, and am observing z-indexing issues while logged in.

I noticed that the original changes that fixed this were reverted in a later commit.

I also saw your comment on 3521111 ✨ Allow configuring the widget position Active adding "default config to not overlap the Gin left toolbar", but I don't understand how that would fix this issue.

Oh dear you're right. I have competing problems I'm trying to solve here. I'll reopen/revisit this.

3521111 is unrelated; that just added the right-side toolbar to the selector list, so that the Editoria11y toggle will pin to the Gin toolbar rather than the left edge if someone sets it to pin left instead of right.

Thanks! I started to dig into a solution for this, but it seems like this issue has a more complicated history than I understand at the moment.

Hello!

We have a similar issue, let me know if this is different enough to necessitate a new ticket. When fully expanded the panel is obsctructed by the Gin toolbar. This screencast captures the problem.

Thank you!

That...should work.

I added an event to the library for when tips are drawn, and use that to iterate the results and modify their z-index. Now only the Editoria11y toolbar, active tips, and tips on content in a modal should draw on top of the Gin toolbar.

And since I was revisiting Drupal's modals anyway, I added some logic to detect when Drupal opens a modal, which temporarily overrides the check roots to only check within the modal and then re-runs the checker. I figure there's no sense tagging things behind the modal, since you can't get to them until the modal closes. Maybe someday I'll generalize that for any opening modal dialog.

I'll wait to tomorrow to tag a release.

Fixed in 2.2.8 → .

I am hoping this is the last time I need to revisit this for the Gin toolbar and the Drupal modal, but I absolutely expect this issue to resurface with other modules. This time I left a lot of notes-to-self, in hopes I don't break Gin again when I address the next round of surprises.

Thank you for your quick response and commit. Z-index issues aren't simple to keep up with, even when it's in your own codebase!

Automatically closed - issue fixed for 2 weeks with no activity.