Interface should show below Gin toolbar

Created on 13 January 2025, 3 months ago

Problem/Motivation

When using the Gin theme with the Gin admin theme and gin Toolbar.

Steps to reproduce

Install the Gin theme and Gin Toolbar.

Proposed resolution

The Editorially interface should be positioned underneath the Gin toolbar.

Remaining tasks

Work out whether this should be fixed in Editoria11y or Gin.

User interface changes

The Editorially interface is positioned underneath the Gin toolbar.

API changes

tBD

Data model changes

TBD

✨ Feature request
Status

Active

Version

2.2

Component

Conflicts with other modules

Created by

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @DamienMcKenna
  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Indeed. The tip dialogs do need to paint over the interface, but the tip marks don't necessarily. Playing with Gin Toolbar, it looks like setting the z-index param to precisely 491 might give what you are looking for on the frontend:

    ...that does run some risks, as absolutely positioned elements could end up with marks being hidden entirely behind Gin. But that is rare, and you could still get to those marks via the "next tip" button on the panel.

    But on the backend...the backend is so much more complicated. Here we have frequent situations where the marks partially intersect the Gin components (to get them off the text someone is editing), and at certain breakpoints CKEditor floats the interface. Using 491 (so the two elements are 501 and 502) can make it so CKEditor draws on top of Editoria11y dialogs, which is no good:

    ...and unfortunately Gin's left and top bars are set to 501 and 502, so there's no number between them I can use.

    In an earlier branch I had separate settings depending on whether CKEditor was present on the page. This is easy, as they are all inheriting a CSS variable that can be changed at will. I could go back to that, so the overdraw would only happen when there was a CKEditor frame under the toolbar -- the marks hide when scrolled out of the visible part of the CKEditor frame.

    Otherwise -- I think I would need Gin (and Drupal core) to change so that the vertical sidebar and the top toolbar had a z-index value available between the two -- 501 and 503 rather than 501 and 502. But I'd be surprised if people were willing to make that big a change. It would help me and possible other modules though...

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Should be fixed in 2.2.1

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Marking fixed for now. Please reopen if you notice issues.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024