Remove composer dependency on old CKEditor 4 library

Created on 13 January 2025, 7 days ago

Problem/Motivation

The 2.0.x branch of this module is compatible with CKEditor 5. In its composer.json it still has a dependency to the old CKEditor 4 library using the 8.x-1.x branch.

Steps to reproduce

Install the module using the 2.0.x branch:

composer require 'drupal/ckeditor_font:^2.0@beta'

Notice that drupal-ckeditor-libraries-group/font is installed and that is not needed.

Proposed resolution

Remove drupal-ckeditor-libraries-group/font from the module's composer.json file.

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇳🇮Nicaragua dinarcon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dinarcon
    • dinarcon committed 1cb90c52 on 2.0.x
      Issue #3499268 by dinarcon: Remove composer dependency on old CKEditor 4...
  • 🇳🇮Nicaragua dinarcon

    Version 2.0.0-beta5 has been released with a fix to this issue.

  • Hi, I'm still using CKEditor 4, and I have a question.
    Is Version 2.0.0-beta5 incompatible with CKEditor 4?
    I have updated 2.0.0-beta4 to 2.0.0-beta5, the following error occurred when creating a node because web/libraries/font was deleted.

    ValueError: Path cannot be empty in file_get_contents() (line 1097 of core/modules/locale/locale.module). 
    _locale_parse_js_file() (Line: 529)
    locale_js_translate() (Line: 367)
    Drupal\ckeditor\Plugin\Editor\CKEditor->getJSSettings() (Line: 82)
    Drupal\editor\Plugin\EditorManager->getAttachments() (Line: 100)
    Drupal\editor\Element->preRenderTextFormat()
    

    Best regards,

  • 🇳🇮Nicaragua dinarcon

    Version 8.x-1.x is only compatible with CKEditor 4. Version 2.0.x is only compatible with CKEditor 5.

    @kubokura could you check if you get the error in a fresh Drupal installation? In either case, please create a new issue and provide steps to reproduce the error.

  • @dinarcon, thank you for reply.
    I will continue to use CKEditor 4 + ckeditor_font 2.0.0-beta4 as long as CKEditor 5 Paste from Word issue #3447491 🐛 CKEditor 5 Paste from Word: image disappeared when reopening Edit tab Active remains unresolved.
    It was just a question, and no further investigation is needed.

Production build 0.71.5 2024