Contrib.social

Add composer.json and gitlab-ci file to run linter and other checks on the module

Open on Drupal.org →
Created on 12 January 2025, 3 months ago

Recommend adding a composer.json file to the module and also add the https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c... to the repo. It will run the available checkers on the code base and also tests. Details in https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

  1. Create the file manually in a git checkout.
  2. Checkout your project.
  3. Create a new file called .gitlab-ci.yml in the root of the project
  4. Copy in the contents of the template: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...
  5. Note: You do not need to copy in any of the other 'include' files, GitLab will reference those directly from the template.
  6. Commit and push your changes.
📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States dmundra Eugene, OR

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dmundra
  • Merge request !3Issue #3499244: Upgrade to Drupal 11 and add gitlab-ci file for checks → (Merged) created by dmundra
  • Pipeline finished with Failed
    3 months ago
    Total: 143s
    #393772
  • Comment 3 months ago →
    🇺🇸United States dmundra Eugene, OR

    Needs upgrade to Drupal 11 to run the tests.

  • Pipeline finished with Failed
    3 months ago
    Total: 296s
    #393870
  • Pipeline finished with Failed
    3 months ago
    Total: 107s
    #393873
  • Pipeline finished with Failed
    3 months ago
    Total: 241s
    #393879
  • Pipeline finished with Success
    3 months ago
    Total: 253s
    #393883
  • Comment 3 months ago →
    🇺🇸United States dmundra Eugene, OR

    In the MR for this issue got the tests passing with Drupal 11 by including the dependency on "drupal/elasticsearch_connector": "^8.0@alpha". I also made some adjustments as well:

    • Cleaned up composer.json
    • Updated tests/src/FunctionalJavascript/IndexFormTest.php to not include extra save step.
    • Updated typos in README and other places, ignored some spellings in the gitlab pipeline.
    • Moved the module to 'Search' package.

    Ready for review. If I need to create a separate MR for just version 11 let me know.

  • Comment 3 months ago →
    🇺🇸United States dmundra Eugene, OR

    Attaching patch as well for folks who want to test with that.

  • Pipeline finished with Success
    3 months ago
    Total: 187s
    #393892
  • Pipeline finished with Skipped
    3 months ago
    #393961
  • First commit to issue fork.
  • Pipeline finished with Skipped
    3 months ago
    #394027
  • Pipeline finished with Skipped
    3 months ago
    #394028
  • Comment 3 months ago →
    System Message
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024