Manually convert jsonapi_test_field_filter_access_jsonapi_entity_field_filter_access

decide to combine several hooks in one issue.

MR is ready for review.

One comment.

Great catch. Thanks. Ready for review.

Looks like layout_builder_extra_field_test_node_view can be simply removed. Because we have LayoutBuilderExtraFieldTestHooks::hook_entity_extra_field_info

I decide to remove layout_builder_extra_field_test_node_view(), IS updated.

Create issue at coder to implement check hook name at Hook attribute 📌 Add rule to check Hook attribute doesn't start with hook_ Active .

I don't follow why

Looks like layout_builder_extra_field_test_node_view can be simply removed. Because we have LayoutBuilderExtraFieldTestHooks::hook_entity_extra_field_info.

LayoutBuilderUiTest::testNewExtraField doesn't test content display.
It just test layout_builder admin manage page: admin/structure/types/manage/bundle_with_section_field/display/default/layout. And this test doesn't check entity display at all. That the reason function layout_builder_extra_field_test_node_view can be removed.

Makes sense, looks good to me.

Reviewed the code. This looks good, changes are all compliant with the original hooks. And lovely to slowly see module files die. ;)

+1 to RTBC from me.

This needs a rebase for the phpstan baseline unfortunately.

Did a quick rebase, since it is only phpstan baseline, setting to RTBC

Committed/pushed to 11.x, thanks!

catch → closed merge request !10884

Not sure what happened, but while this passed commit checks, it broke HEAD phpstan - I regenerated the baseline and pushed a follow-up commit, so should be OK again now.

Weird. Was sure to pull 11.x and accept theirs in git.

Thanks a lot for rebasing and merge it.

@bbrala, yes, but this issue removed some functions from baseline, so accepting theirs removed the removal I think. You can see that the pipelines failed. In that case after rebasing you have to regenerate the baseline to pick up the updates.

I'm not sure how commit checks passed in that case, but baseline has been weird in general I think, there is another issue where the pipeline is passing but phpstan is detecting changes.

I think commit checks passed because there were no baseline changes so it only checked the new files, and I obviously didn't check the MR run.

TIL will be more carefully with phostan diffs

No worries, it can be confusing, here is the command to regenerate:

./vendor/bin/phpstan analyze --configuration=./core/phpstan.neon.dist --memory-limit=-1 --generate-baseline=core/.phpstan-baseline.php