Add rule to check Hook attribute doesn't start with hook_

PR created https://github.com/pfrenssen/coder/pull/260

The problem is hooks like hook_hook_info.

Now that one won't ever be oop, but we can't guarantee contrib or custom code hasn't done something similar.

Thanks, approach makes sense, I think we can do this. Left some comments on the PR.

Please add special handling for hook_hook_info(). There are not other hooks in core that would be falsely flagged, I don't think we need to care about other special cases in contrib or custom code (people can make PHPCS ignore directives).

We don't need to worry about hook_hook_info, it cannot be oop anyways.

My point was we shouldn't make assumptions about contrib and custom code.

If you think the ignore rule is enough then it's ok with me, this covers the vast majority of the cases.

@klausi thanks for your review, I update PR and it's ready for review.

@nicxvan, I add special handling for hook_hook_info(). But still not sure about it.

We don't need to handle hook_hook_info it will never be oop.

Thanks @nicxvan, I remove special handling for "hook_hook_info()".

Decide to improve Hook attribute tests 🐛 Improve HookCollectorPass test Active .

Thanks, I think the sniff is almost ready!

Thanks for review, PR updated and ready for the review.

Merged, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.