- Issue created by @benjifisher
- πΊπΈUnited States benjifisher Boston area
I have never before used three commits for a net +2/-3 change, but I did see three different problems with that code.
As long as I am editing this file, should I add return type declarations?
- πΊπΈUnited States benjifisher Boston area
At first, I missed that the return values were strings
'true'
and'false'
, not booleanstrue
andfalse
. I also forgot to create the MR after pushing my changes, which is just as well. - πΊπΈUnited States dww
Thanks noticing this was requested in the parent issue, for opening it and for the MR.
Change is simple and small. Definitely improvement and cleanup. Issue summary and title are clear and accurate.
Pipeline is all green.
I see nothing to improve. Ready to be committed. π
Automatically closed - issue fixed for 2 weeks with no activity.