- Issue created by @heddn
- 🇳🇴Norway hansfn
Thanks a lot for the testing and patch, heddn. I obviously haven't had time to test the module on D11. I was planning to, but paid work ...
It seems you have made very reasonable changes, but I would have preferred one PR for the Mime stuff and another for the Token stuff. Or does the token stuff also break the site? Looking at the issue, you are only pointing to the defines as breakers. Do you mind the extra work?
So, some questions because I'm not following Drupal development closely:
- How long has "type: mapping" in the schema been wrong ...
- How long has "type: mapping" in the schema been wrong ...
- Why do you create a ViewsSendMimeInterface? Is it a requirement? I don't expect there to be anymore implementations of that interface than the one you created?
Again, I really appreciate that you help keeping this module a live. It really should be completely rewritten, but I guess it works well enough for some people as is. Well, not for people on D11. And maybe it was broken for 10.3 also. It seems I last tested with 10.1.5
- 🇳🇴Norway hansfn
Merging didn't seem to change status to fixed. Doing that now. Again - thanks heddn.
Automatically closed - issue fixed for 2 weeks with no activity.