- Issue created by @effulgentsia
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Implemented 📌 When demo_mode, limit component list to only SDCs, not blocks Active . Tackling this next.
This might actually always make sense? 🤔
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Actually … there's a much simpler way to achieve what's described in the issue summary! 😄
And it uses Recipes infrastructure to achieve it!
Let Drupal CMS just mark all
Component
config entities as disabled (using thedisable
config action), except the ones the Drupal CMS demo wants to be enabled?Pinged @phenaproxima.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
… LOL! Posting that comment over in the
drupal_cms
issue queue made me spot 📌 Disable default XB components Postponed , which is AFAICT exactly what I wrote in #3? 🤓 - 🇳🇱Netherlands balintbrews Amsterdam, NL
Yes, which I proposed in #3497389-19: Implement designs for Heading component within Olivero for XB → . 🙂
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Fleshed out the proposal in #3 in more detail over at #3497596-4: Disable default XB components → .
EDIT: cross-posted with @balintbrews: hah, great! I simply found it thanks to @pameela adding it as a related issue over there! :D Credited you both 😊 Too bad @effulgentsia didn't know about that — would've saved a quite a bit of back-and-forth.
- 🇫🇮Finland lauriii Finland
Change ComponentPluginManager or something it delegates to, to only create Component config entities for SDCs provided by the active theme (and not its subthemes or modules).
I'm wondering if we should do this within the discovery or if we should filter the list in run time. If we did this, we should also group the components in the UI by theme instead of a single list of all components.
Let Drupal CMS just mark all Component config entities as disabled (using the disable config action), except the ones the Drupal CMS demo wants to be enabled?
+1 for using that for now as a workaround.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
If we did this, we should also group the components in the UI by theme instead of a single list of all components.
+1 — do we have designs for that?
- 🇺🇸United States phenaproxima Massachusetts
I committed 📌 Disable default XB components Postponed to Drupal CMS, which is a fine workaround, so this is probably no longer a dependency critical. Phew!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Yay, https://git.drupalcode.org/project/drupal_cms/-/commit/1414cb5d4829c704f... looks very nice! 😄