Gitlab yml is out of date

Well, the yml is now compatible, but the tests are all broken. I had a go at repairing the dependency scanning job using https://docs.gitlab.com/ee/user/application_security/dependency_scanning... but I think I would need maintainer access to do it fully.

The audit fails because there's an old dependency on rollup:2.57.0 which is brought in by test-runner among other things:

a11y_autocomplete % yarn why rollup -R
└─ @drupal/autocomplete@workspace:.
   ├─ @web/test-runner@npm:0.13.22 (via npm:^0.13.22)
   │  └─ @web/dev-server@npm:0.1.24 (via npm:^0.1.24)
   │     ├─ @web/dev-server-rollup@npm:0.3.10 (via npm:^0.3.10)
   │     │  └─ rollup@npm:2.57.0 (via npm:^2.56.2)
   │     └─ rollup@npm:2.57.0 (via npm:*)
   └─ rollup@npm:2.60.1 (via npm:^2.60.1)

The tests don't run with the current set up dependencies because pnp is complaining about short circuits. I tried adding the explicit shortCircuit: true return parameters in resolve and load but then it failed on webpack (only). (didn't commit)

This needs someone who understands this setup to give it an overhaul, I'm out of my depth :(

lint and audit jobs are passing.

Tests are running, but one is failing in Firefox. Can someone familiar with the tests look at it?

One of the audit errors was for eslint. Upgrading that and eslint-plugin-jsdoc as required introduced a lot of jsdoc lint warnings. Therefore, I set --max-warnings=-1 temporarily to keep the warnings from causing job failure. Someone will need to review the warnings and tweak the rules or the code.

I upgraded both the playwright and main docker images.

For the main image, I used drupalci/php-8.3-apache:production because the drupalci images are used in the gitlab_templates project.

I reasoned that there would be maintenance benefits with using the "official" images, and there might be a caching benefit in Gitlab. Also, the drupalci image already has git.

Another audit error was for rollup-plugin-terser, which minifies the build artifact a11y.autocomplete.min.js. After switching to @rollup/plugin-terser, the resulting a11y.autocomplete.min.js is slightly different than before. So, it should be checked.

The browserlist DB still needs updating.

I made the changes discussed in Slack and updated the IS.

Details on the logic changes are in the comments and commit messages.

Pipeline is green.

Thanks a lot for getting that resolved!

Automatically closed - issue fixed for 2 weeks with no activity.