- Issue created by @poker10
- πΈπ°Slovakia poker10
Some related discussion from Slack: https://drupal.slack.com/archives/C072BF486FN/p1736266751121509
- π¦πΊAustralia pameeela
I'm fine with removing it, I think that is better if it results in a confusing experience.
- Merge request !402Issue #3497951: Consider removing languages from the installer β (Merged) created by poker10
- πΈπ°Slovakia poker10
Created an MR which removed the included JS and CSS files and hides the markup from the template. Not sure if we also want to remove the whole CSS and JS files from the repo, as there is a code which will be used in the future when multilanguage recipe will be added, but if yes, I think it can be done easily.
- πΊπΈUnited States phenaproxima Massachusetts
Go ahead and remove them; we can always get them back from the Git history.
- πΊπΈUnited States phenaproxima Massachusetts
You'll probably test at least one test failure, since the presence of the languages is exposed to drupalSettings: https://git.drupalcode.org/project/drupal_cms/-/blob/1.x/project_templat...
- πΈπ°Slovakia poker10
Yeah, thanks! Find out that we need to remove also InstallerFormBase.php. Tests seems to be green now, so hopefully ready to review again.
-
phenaproxima β
committed bc8b48e7 on 1.x authored by
poker10 β
Issue #3497951 by poker10, pameeela: Remove languages from the installer
-
phenaproxima β
committed bc8b48e7 on 1.x authored by
poker10 β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x. Thanks!
-
phenaproxima β
committed 17828840 on 1.0.x authored by
poker10 β
Issue #3497951 by poker10, pameeela: Remove languages from the installer
-
phenaproxima β
committed 17828840 on 1.0.x authored by
poker10 β