Convert remaining tests to use PerformanceTestTrait::assertMetrics()

I use the following command to get all remaining tests to convert

grep -rlE 'getQueryCount\(\)|getCacheGetCount\(\)|getCacheSetCount\(\)|getCacheDeleteCount\(\)|getCacheTagChecksumCount\(\)|getCacheTagIsValidCount\(\)|getCacheTagInvalidationCount\(\)' ./core --exclude=PerformanceTestTrait.php --exclude=StandardPerformanceTest.php --exclude=PerformanceData.php

Which has result :

grep -rlE 'getQueryCount\(\)|getCacheGetCount\(\)|getCacheSetCount\(\)|getCacheDeleteCount\(\)|getCacheTagChecksumCount\(\)|getCacheTagIsValidCount\(\)|getCacheTagInvalidationCount\(\)' ./core --exclude=PerformanceTestTrait.php --exclude=StandardPerformanceTest.php --exclude=PerformanceData.php

./core/modules/navigation/tests/src/FunctionalJavascript/TopBarPerformanceTest.php

In TopBarPerformanceTest.php, conversion still have occurrences, so i have to exclude it after fixing it. Excluded StandardPerformanceTest and TopBarPerformanceTest should be looked manually since they are excluded from search.

grep -rlE 'getQueryCount\(\)|getCacheGetCount\(\)|getCacheSetCount\(\)|getCacheDeleteCount\(\)|getCacheTagChecksumCount\(\)|getCacheTagIsValidCount\(\)|getCacheTagInvalidationCount\(\)' ./core --exclude=PerformanceTestTrait.php --exclude=StandardPerformanceTest.php --exclude=PerformanceData.php

I came across this issue through a referenced ticket. I searched for similar and found only TopBarPerformanceTest.php in the testTopBarPerformance method. The MR has already been created.checking for pipline failure .

There was no need to push other commits on MR, only relaunch the failing test

Yes you are right , This is just a random failure , i have just rebase this MR.

Reviewed the MR, added one comment.

Ok, is that 2x code reviews, now? Move to RTBTC?

Ok, is that 2x code reviews, now? Moving to RTBTC.

All tests are green. Seems good to go.

Committed/pushed to 11.x, thanks!

catch → closed merge request !10982

Automatically closed - issue fixed for 2 weeks with no activity.