Update to use FieldWidget Attribute

Created on 4 January 2025, about 1 month ago

Problem/Motivation

Attribute should be used now that 10.2 is out of support.

Proposed resolution

Update the field widget from using annotation to using attribute and update composer.json and core_version_requirement to ^10.3 || ^11

Remaining tasks

- do it
- update gitlab CI configuration to test previous major as well as next major.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States mradcliffe USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mradcliffe
  • First commit to issue fork.
  • Pipeline finished with Success
    29 days ago
    Total: 142s
    #387286
  • 🇺🇸United States mradcliffe USA

    Thank you for the merge request, @vinayakamk47. Changes look good so far. There a couple of things to still to do:

    1. Update .gitlabci.yml to support testing on previous major
    2. Update link_selection_handler.info.yml

  • First commit to issue fork.
  • Pipeline finished with Success
    11 days ago
    Total: 145s
    #404871
  • 🇺🇦Ukraine dlevchik

    Updated core_version_requirement to support Drupal 10.3+. Allowed testing on previous major on .gitlabci.yml

    The only thing is, I don't see "Stage: test" on MR. Maybe it needs to be enabled somewhere in the repository settings?

    Sorry, I'm no expert here

  • 🇺🇸United States mradcliffe USA

    Thanks for your fixes on the merge request, @dlevchik.

    The module currently does not have any unit or functional tests, but it still runs through phpcs and phpstan jobs in the pipeline. In the merge request, the Code Quality and Test summary collapsible sections show any current test or "test" result.

Production build 0.71.5 2024