Move helpers in batch_test.module and delete it

Not sure what I'm missing, but there are errors, there were a lot of changes. I tried using static, and using the class directly like I've done in projects and it still fails.

Add parent issue.

I didn't want to create the MR cause all of the batch tests fail, I'll create it so you can see though.

Ok you can see the failures now

I install batch_test module on local and visit batch-test/no-form. Here the error.
'Fatal error: A void function must not return a value in /var/www/html/core/modules/system/tests/modules/batch_test/src/BatchTestHelper.php on line 244'

Thank you so much! I knew I was missing something obvious!

Thanks for MR, please check my feedback.

Addressed it all, I'll wait on tests.

Thanks, LGTM.

Went to commit this, however phpstan isn't happy. Not sure why this didn't show up in the pipeline.

FILE: ...al/core/modules/system/tests/modules/batch_test/src/BatchTestCallbacks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 194 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
--------------------------------------------------------------------------------

That is weird, I ran the baseline locally and it didn't show up.

I added string translation trait and rebased.

Looks like some random fails. Please double check.

Failure is on head, I can rebase once 📌 Move helpers in ajax_forms_test.module and delete it Needs work is in.

Thanks, in this case LGTM.

One question on the MR.

I addressed all of the feedback

All feedback appears to be addressed.

Committed/pushed to 11.x, thanks!

catch → closed merge request !10768

Automatically closed - issue fixed for 2 weeks with no activity.