After upgrading to 10.4 and installing https://www.drupal.org/project/views_core_entity_reference → I was trying to track down why the ordering in my taxonomy_term entity reference select list filters weren't matching what we had on 10.3.
I tracked it down to this line which short-circuits the custom Taxonomy based querying if a $match or $limit is passed.
In the previous iteration of this filter, there was no $limit parameter passed, but the one that was eventually committed does.
Install 10.4
Install views_core_entity_reference
Add a Term reference field for a Vocabulary using the Select list widget
Add terms to the Vocabulary and reorder them to a non-alphabetical weighting
Notice the terms are sorted alphabetically in the filter.
Not too sure, I believe the $limit there is to reduce performance overheads of loading a massive list of options.
Figure out a fix...
Active
11.1 🔥
views.module
Just came back to this and realised this is working as designed.
Term fields should use the taxonomy_index_tid filter, not the entity_reference one. The views_core_entity_reference module does not override these filters, my issue was with a custom entity type setting them in the views data handler.