Uninstalling a module deletes all views that have third-party settings by that module

Created on 1 January 2025, 2 months ago

Problem/Motivation

When a module saves third-party settings on a view, uninstalling that module will delete the view (instead of just removing the third-party settings).

This exact problem is normally taken care of by \Drupal\Core\Config\Entity\ConfigEntityBase::onDependencyRemoval(). However, the Views entity class overrides the method but fails to call the parent (or fix the problem itself).

Steps to reproduce

Write a small module that adds third-party settings to a view.
Go to the “Uninstall” page and select your module.
On the confirm form, you will see that the view will get deleted.

Proposed resolution

Unless there is a good reason not to do that, I would suggest just calling the parent method.

Remaining tasks

Agree on the solution.
Implement it.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

views.module

Created by

🇦🇹Austria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.

Merge Requests

!10760Uninstalling a module deletes all views that have third-party settings by that module
Open
🇦🇹Austria drunken monkey
updated 2 months ago

Comments & Activities

Issue created by @drunken monkey
Merge request !10760Resolve #3496867: Add a call to the parent method to View::onDependencyRemoval(). → (Open) created by drunken monkey
Comment 2 months ago →
🇦🇹Austria drunken monkey Vienna, Austria
My trivial suggested solution is implemented in this MR.
Let’s see whether the pipelines succeed, otherwise we might already know the reason why this is currently not done.
Pipeline finished with Success
2 months ago
Total: 551s
#383327
Comment 2 months ago →
🇺🇸United States smustgrave
This has been seen in better exposed filters, Probably getting test coverage can help show the problem and if the approach works
Comment 2 months ago →
🇺🇸United States nicxvan
If after all this time this was all that was needed...

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Uninstalling a module deletes all views that have third-party settings by that module

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Merge Requests

!10760Uninstalling a module deletes all views that have third-party settings by that moduleOpen

Comments & Activities

!10760Uninstalling a module deletes all views that have third-party settings by that module
Open