Uninstalling a module deletes all views that have third-party settings by that module

My trivial suggested solution is implemented in this MR.
Let’s see whether the pipelines succeed, otherwise we might already know the reason why this is currently not done.

This has been seen in better exposed filters, Probably getting test coverage can help show the problem and if the approach works

If after all this time this was all that was needed...

I added a test.

Bummer doesn't actually solve the problem for better_exposed_filters but how does third_party_settings get added anyway?

Bummer doesn't actually solve the problem for better_exposed_filters but how does third_party_settings get added anyway?

Yeah, I noticed that, but forgot to mention it last night. Since BEF doesn't use third party settings to modify views, this fix won't apply to that problem.

Third party settings are applied to config entities via the setThirdPartySetting() function.

Thanks a lot for writing the test, looks great!
I just made a few minor changes, now I’d say this is RTBC.

Nit but should change the wording of the last commit. Comes off like someone owns this so not sure read right

I added a suggestion for that comment.

I chose:

Tests removing third-party settings when a provider module is uninstalled.

That is better!

Works for me. Probably good to self RTBC after

Right on.

Don't want to hold this up, but I think a follow-up to change views to _never_ delete due to config dependencies but just disable the view. There are lots of similar issues open where views get deleted due to a role or node type dependency in a condition that will not be fixed by this, this specifically only fixes third party settings.

Opened 📌 Don't delete view due to config dependencies being deleted Active