Fix tests

One Nightwatch test is skipped because it is probably no longer relevant (pagination is no longer remembered between sources). The other one involves navigating through the PB UI with the keyboard, and we oughta just convert that to a functional JS test under PHPUnit, which 99% of our functional JS tests are written with anyway. Nightwatch is probably going away as core adopts Playwright, so why bother fixing Nightwatch tests (which nobody can figure out how to run locally)?

Thanks for taking a look at this @phenaproxima. In that case, would it make sense to remove both tests immediately, with Nightwatch permanently gone, and create a fresh follow up issue, to deal with the still relevant test (navigating through the PB UI with the keyboard) and convert that to a functional JS test under PHPUnit?

That way, the tests are not failing until (who knows when?) it will get fixed. Having chronically failing tests results in false positives, and users wasting time, which could have been spent productively on fixing other issues.

I have updated the Issue Summary, feel free to update or remove the proposal, whatever you think is the best method.

@ressa, yes - let's do that.

Thanks for fast feedback @chrisfromredfin, I created a child issue 📌 Convert navigating the PB UI with the keyboard Nightwatch test to a functional JS test under PHPUnit Active .

Well look at that, we're green again! 😜

Automatically closed - issue fixed for 2 weeks with no activity.