- Issue created by @roromedia
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I have the feeling this MR will fundamentally break the module.
- 🇺🇸United States ultimike Florida, USA
I have to agree with @bramdriesen on all of his comments. I would like to see this MR cleaned up a bit and a test added before considering this change (especially because this is a bit of an edge case and a workaround exists.)
-mike
- 🇮🇪Ireland lostcarpark
The change in the MR seems overcomplicated, and I'm not sure it fixes the problem that the module won't install if there's a Markdown filter already existing.
Wouldn't a much simpler solution be to move
config/install/filter.format.markdown.yml
toconfig/optional/filter.format.markdown.yml
?This would mean that if there's a existing Markdown filter, it would be left as-is, and it would be up to the site builder to apply Markdown Easy to it. I feel this is reasonable as we don't know what might be in an existing filter, so we shouldn't change it. I think expecting a manual reconfiguration of the text filter is reasonable.
- Status changed to Needs review
22 days ago 10:32pm 11 March 2025 - 🇺🇸United States aasarava San Diego
I agree with the solution proposed by @lostcarpark. It's much simpler and it works. If you're migrating from the markdown module or already have a markdown filter for any reason, you shouldn't get stuck trying to install markdown_easy.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Patch looks good, but easier for the maintainer if it's a MR.