Markdown Easy won't install if Markdown Text Filter already exists

I have the feeling this MR will fundamentally break the module.

I have to agree with @bramdriesen on all of his comments. I would like to see this MR cleaned up a bit and a test added before considering this change (especially because this is a bit of an edge case and a workaround exists.)

-mike

The change in the MR seems overcomplicated, and I'm not sure it fixes the problem that the module won't install if there's a Markdown filter already existing.

Wouldn't a much simpler solution be to move config/install/filter.format.markdown.yml to config/optional/filter.format.markdown.yml?

This would mean that if there's a existing Markdown filter, it would be left as-is, and it would be up to the site builder to apply Markdown Easy to it. I feel this is reasonable as we don't know what might be in an existing filter, so we shouldn't change it. I think expecting a manual reconfiguration of the text filter is reasonable.

I agree with the solution proposed by @lostcarpark. It's much simpler and it works. If you're migrating from the markdown module or already have a markdown filter for any reason, you shouldn't get stuck trying to install markdown_easy.

Patch looks good, but easier for the maintainer if it's a MR.

lostcarpark → changed the visibility of the branch 3496182-markdown-easy to hidden.

I wrote a new test class, InstallTest to create a Markdown input format, then install the Markdown Easy module. I verified this failed, then moved filter.format.markdown.yml into the config/optional directory, and verified the test passed.

Pushed as MR !17.

Ready for review.

Note that this change is against the 1.0.x branch. I feel this is correct as it's a bugfix.

However, once RTBC, it should be cherry-picked into a second MR against the 2.0.x branch.

Looks super-duper to me. Merged into 1.0.x and cherry-picked into 2.0.x

@lostcarpark - thanks for the test!

-mike

Automatically closed - issue fixed for 2 weeks with no activity.