- Issue created by @dieterholvoet
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks a lot for reporting this problem and already proposing a fix!
It indeed seems like we misunderstood the purpose of theversion
key when initially creating thesearch_api.libraries.yml
file. Your explanation makes sense and the code inJsCollectionRenderer::render()
seems to corroborate it as well. Still, as I have very little expertise in this area of Drupal development I’ll leave this issue open another week or so to give others a chance to weigh in before merging. - 🇧🇪Belgium dieterholvoet Brussels
If it can be a reassurance: a lot of other major contrib modules have the same issue and have already committed the fix. I linked a couple of them.
-
drunken monkey →
committed e7dce793 on 8.x-1.x authored by
dieterholvoet →
Issue #3495876 by dieterholvoet, drunken monkey: Removed VERSION from...
-
drunken monkey →
committed e7dce793 on 8.x-1.x authored by
dieterholvoet →
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks, very helpful! Then yes, it seems clear that this is the right thing to do.
Merged.
Thanks a lot again! Automatically closed - issue fixed for 2 weeks with no activity.