- Issue created by @phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
This will need test coverage to prevent it from regressing.
- First commit to issue fork.
- Merge request !656#3495328:Pressing Enter after entering search text causes a page reload β (Merged) created by utkarsh_33
Added test as requested.If this is enough to cover the use case that we are fixing here then can we remove the needs test tag?
- πΊπΈUnited States phenaproxima Massachusetts
I'm not entirely sure that this test covers what we want. The problem is that the whole page reloads when you do a search, not that the URL changes. So I think a more realistic test might be:
- We change some other filter value (or set some in-memory JS flag, like
window.isSingleLoad = true
) - We search and press Enter
- Confirm that the other filter value is unchanged (or the in-memory flag is still there), which would prove that the page did not reload
I might be missing something here, though. What do you think?
- We change some other filter value (or set some in-memory JS flag, like
- First commit to issue fork.
-
chrisfromredfin β
committed 46ab2a28 on 2.0.x authored by
utkarsh_33 β
Issue #3495328: Pressing Enter after entering search text causes a page...
-
chrisfromredfin β
committed 46ab2a28 on 2.0.x authored by
utkarsh_33 β
- πΊπΈUnited States chrisfromredfin Portland, Maine
Reviewed, manually tested. Fixed.
Automatically closed - issue fixed for 2 weeks with no activity.