Pressing Enter after entering search text causes a page reload

Created on 20 December 2024, 6 months ago

Problem/Motivation

If you enter some search text in Project Browser and press Enter, the whole page is reloaded. That shouldn't happen - it should instead do a search for your query.

🐛 Bug report
Status

Active

Version

2.0

Component

User experience

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • 🇺🇸United States phenaproxima Massachusetts

    This will need test coverage to prevent it from regressing.

  • First commit to issue fork.
  • Pipeline finished with Failed
    6 months ago
    Total: 436s
    #378778
  • 🇮🇳India utkarsh_33

    Added test as requested.If this is enough to cover the use case that we are fixing here then can we remove the needs test tag?

  • Pipeline finished with Failed
    6 months ago
    Total: 395s
    #378789
  • Pipeline finished with Failed
    6 months ago
    Total: 467s
    #384632
  • 🇺🇸United States phenaproxima Massachusetts

    I'm not entirely sure that this test covers what we want. The problem is that the whole page reloads when you do a search, not that the URL changes. So I think a more realistic test might be:

    • We change some other filter value (or set some in-memory JS flag, like window.isSingleLoad = true)
    • We search and press Enter
    • Confirm that the other filter value is unchanged (or the in-memory flag is still there), which would prove that the page did not reload

    I might be missing something here, though. What do you think?

  • 🇺🇸United States phenaproxima Massachusetts

    Think I got this fixed.

  • Pipeline finished with Failed
    6 months ago
    Total: 362s
    #389147
  • Pipeline finished with Failed
    6 months ago
    #389152
  • Pipeline finished with Skipped
    6 months ago
    #389209
  • First commit to issue fork.
  • 🇺🇸United States chrisfromredfin Portland, Maine

    Reviewed, manually tested. Fixed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    5 months ago
    Total: 1002s
    #423355
  • Pipeline finished with Success
    5 months ago
    Total: 959s
    #423924
  • Pipeline finished with Skipped
    5 months ago
    #423945
  • Pipeline finished with Success
    22 days ago
    Total: 232s
    #518433
Production build 0.71.5 2024