Remove the ability for the project_browser.browse route to take a project ID

I have created the patch apply changes according to issue .please review it .

That looks like a good start, but we will need it as a merge request (we're no longer using patches) and I think there is at least one other place where the #id property is used in the ProjectBrowser render element that has to be removed.

Working on it.

Created a MR.

Patch is converted to MR but Feedback is not addressed mentioned in #5,

According to #5, there is another place where the #id is being used, which needs to be removed. Upon reviewing the code, I found that in the attachProjectBrowserSettings method, the #id is being attached to Drupal settings. Additionally, in the getDrupalSettings method, the $id parameter is passed and used in a condition (empty($id)) to determine the behaviour of the $package_manager array. Since the $id argument has already been removed from the route, should this parameter and its associated logic also be removed from the getDrupalSettings method?

Thanks for asking. We should probably keep the logic from that if block, but remove the if itself. In other words, what's in there should always run.

I have updated the getDrupalSettings method for #id, removing the id condition while keeping the inner logic unchanged.
Additionally, since the $id parameter has been removed from the method, I have also removed the following doc block comment.
During testing, I noticed that ?id was being appended to the URL for all the tabs. After debugging, I removed the id from the Local task, and it is now working fine. Moving this for your review. Kindly review and let me know if anything else needs to be updated.

That looks good to me. The test failures do not appear to be related. Thanks!

This feels good to remove cruft from a feature we no longer have! 💪

Automatically closed - issue fixed for 2 weeks with no activity.