- Issue created by @jan kellermann
- Merge request !63#3495242: Add preprocess and service entity for simple_gmap. → (Merged) created by jan kellermann
- 🇬🇧United Kingdom eyedrops
works fine.
- I would like you to add the GMaps service to the README. The description of the
preprocess_field
setting refers to a list of services found in the README. It should be kept up to date. - The new code for
klaro_preprocess_field
does not check if the formatter is actually provided by thesimple_gmap
module, nor does it check if it is installed or if the GMaps service is active in klaro before creating the markup. If you can somehow limit the scope of the logic, I would prefer if you did that instead.
- I would like you to add the GMaps service to the README. The description of the
- 🇩🇪Germany jan kellermann
Thank you for feedback and testing.
I have added the information to the readme file.
I don't expect any security implications if we don't check whether the module is installed. If someone has access to the code and can manipulate field values, they can also inject code elsewhere. We just do the rendering and let the Klaro helper check the result.
So I set the state to RTBC.
-
jan kellermann →
committed 0e829dc3 on 3.x
#3495242: Add preprocess and service entity for simple_gmap.
-
jan kellermann →
committed 0e829dc3 on 3.x
- Status changed to Fixed
about 1 month ago 8:44pm 24 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.