Footer needs to be styled.

After fixing the issue.

Thanks for this.

I think the challenge here is knowing how to style the footer.

A little background

I believe the styling from the footer is taken from Bootswatch themes where no such thing really exists see screenshot.

Even if we look at getbootstrap site, the footer is not defined as a component afaict. However we do have site specific styles there that does seem to utilise the in built grid system (See screenshot). This is usually implemented using container, row and col classes. No need to re invent the wheel here. Better to use the predefined breakpoints etc.

Personally I do not really use a footer on my sites, however I am not averse to implementing some improvements to allow a user to implement a different type of footer and how it behaves. For some ideas for the sort of variations there are some more examples here:

https://mdbootstrap.com/docs/standard/navigation/footer/examples-and-cus...

Any variations should be designed to be responsive etc.

Ok looking at the footer I can see we currently have support for 5 footer regions.

This is output like so:

      {% block footer %}
        <div class="{{ container }}">
          {% if page.footer_first or page.footer_second or page.footer_third or page.footer_fourth %}
            <div class="site-footer__top clearfix">
              {{ page.footer_first }}
              {{ page.footer_second }}
              {{ page.footer_third }}
              {{ page.footer_fourth }}
            </div>
          {% endif %}
          {% if page.footer_fifth %}
            <div class="site-footer__bottom">
              {{ page.footer_fifth }}
            </div>
          {% endif %}
        </div>
      {% endblock %}

This shows that footer_fifth appears to be handled slightly differently, i.e. it has a different container class site-footer__top vs site-footer__bottom

So I am thinking it might be possible to add a variation for the footer from the default, (current). This might be useful should anyone want to implement a different variation in the future. So perhaps the option to change how a footer behaves.

In other words may be an option form the style admin page to change how a footer behaves.

Certainly if there is no footer or perhaps a simple footer, this is probably not relevant.

For others who want to display a single or even multiple menu items I agree these should first stack (one column mobile) and then respond to larger viewports (unlike get bootstrap that shows 2 columns on mobile!). IIRC this should also respond depending on how many menus or columns are shown. Certainly the example you have shown should be fairly easy to implement as all columns are equal width at least on larger viewports.

Thinking about this I am not really sure why we need 5 footers as it is also possible and arrange 4 or 5 blocks in one or more regions. Maybe it would be better to simplify this and instead have types of footer?

Do you see any issue with removing footers page.footer_second, page.footer_third and page.footer_fourth ?

Anyway, now I have started to look at the footer I can see that it may be possible to:

1. simplify the existing implementation.
2. Add support for variations. This could be done either at a config level (select type of footer from admin) or even from a region level (choose the footer type or region you want to use by placing a block).

Hi @2dareis2do, I would be happy to work on your suggestions.

Thinking about this I am not really sure why we need 5 footers as it is also possible and arrange 4 or 5 blocks in one or more regions. Maybe it would be better to simplify this and instead have types of footer?

Do you see any issue with removing footers page.footer_second, page.footer_third and page.footer_fourth ?

Based on your suggestion, should I consolidate these into a single region and allow blocks to be placed and arranged accordingly?

For example, would something like the following be a better approach ??

<div class="site-footer__top clearfix">
        {{ page.footer_first }}
 </div>

Let me know your thoughts, and I’ll proceed accordingly. Thanks! 😊