Web component flagged as missing text

Created on 19 December 2024, 3 days ago

Problem/Motivation

The module is incorrectly flagging our web component as having empty text.

I have added the selector shadow host for the web component to the module's Advanced configuration section in the module's settings. I did this by opening the accordion “Custom tests and components”, and then going to the setting “Scan inside these Web components” and then adding pds-heading

Steps to reproduce

Here is a link to a test page created that has multiple Heading web components that are being flagged as having empty text. Please note that Editoria11y is correctly flagging the issue for skipped headings, however, it incorrectly flags the web component as missing text. Screenshots attached for what we are seeing in the Admin for this test page: https://pr-1512-principalcom.pantheonsite.io/kitchen-sink-test-pds-header-web-components

Proposed resolution

Editoria11y no longer flags this web component as missing text.

🐛 Bug report

Status

Active

Version

2.1

Component

Bugs

Created by

🇺🇸United States andrewozone

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @andrewozone
Comment 2 days ago →
🇺🇸United States itmaybejj
Yeah; Editoria11y and Sa11y are running a homebrewed abbreviated version of the accessible name algorithm that roughly matches markup that is possible to create with CKeditor and Gutenberg. Haven't added slot name computation yet.

It won't be hard. I'll look into wrapping it into the next release.
Comment 2 days ago →
🇺🇸United States itmaybejj
Comment 2 days ago →
🇺🇸United States itmaybejj
OK I've added the ability to read text in slotted templates and added this case to my automated testing.

I am going to wait until January to tag a release though just in case this breaks something unexpected.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024