Convert profile hooks

Created on 19 December 2024, about 1 month ago

Problem/Motivation

Profiles were not part of the automated conversion.

Steps to reproduce

N/A

Proposed resolution

Convert the profiles hooks.

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

📌 Task
Status

Active

Version

11.0 🔥

Component

extension system

Created by

🇺🇸United States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nicxvan
  • Merge request !10642Convert standard profile → (Open) created by nicxvan
  • Pipeline finished with Failed
    about 1 month ago
    Total: 569s
    #376103
  • Pipeline finished with Failed
    about 1 month ago
    Total: 138s
    #376105
  • Pipeline finished with Success
    about 1 month ago
    Total: 939s
    #376111
  • 🇺🇸United States smustgrave

    Appears to be 1 test profile "testing_hooks" with a profile file that could probably be converted here too thoughts?

  • 🇺🇸United States nicxvan

    That profile is explicitly testing that procedural hooks are picked up.

  • 🇺🇸United States nicxvan
  • Pipeline finished with Success
    27 days ago
    Total: 1098s
    #378604
  • 🇺🇸United States smustgrave

    In that case this looks fine.

  • 🇬🇧United Kingdom alexpott 🇪🇺🌍

    Committed e1e072f and pushed to 11.x. Thanks!

    The phpstan baseline has been manually edited - please don't do that. PHPStan should be the only thing that generates it.

    diff --git a/core/.phpstan-baseline.php b/core/.phpstan-baseline.php
    index 90302bc1c62..a4b7ee050fb 100644
    --- a/core/.phpstan-baseline.php
    +++ b/core/.phpstan-baseline.php
    @@ -54604,7 +54604,6 @@
     	'path' => __DIR__ . '/profiles/minimal/tests/src/Functional/MinimalTest.php',
     ];
     $ignoreErrors[] = [
    -	// identifier: missingType.return
     	'message' => '#^Method Drupal\\\\Tests\\\\standard\\\\Functional\\\\StandardTest\\:\\:assertConfigSchema\\(\\) has no return type specified\\.$#',
     	'identifier' => 'missingType.return',
     	'count' => 1,
    

    Fixed on commit by running vendor/bin/phpstan analyse -c core/phpstan.neon.dist --generate-baseline=core/.phpstan-baseline.php

    • alexpott committed e1e072ff on 11.x
      Issue #3494921 by nicxvan, smustgrave: Convert profile hooks
      
  • 🇺🇸United States nicxvan

    Thanks! I'll use that command, I only really used that for bulk changes so there are quite a few issues out there with manual updates, but I can update them as I come across them.

  • 🇫🇮Finland lauriii Finland

    For some reason, I'm getting occasional PHP warnings after this change:

    Warning: include_once(/var/www/html/drupal/core/profiles/standard/standard.profile): Failed to open stream: No such file or directory in include_once() (line 160 of /var/www/html/drupal/core/lib/Drupal/Core/Extension/Extension.php)
    
  • 🇺🇸United States smustgrave

    Can confirm I saw that this too this morning after doing drush cr. Didn't know where it came from thanks @lauriii

  • 🇺🇸United States nicxvan

    On new or existing sites?

  • 🇺🇸United States smustgrave

    For me it was an existing site locally. I pulled latest changes and ran drush cr and got the warning.

    Second cr no warning

  • 🇺🇸United States nicxvan

    Yeah that will probably happen for each module or profile file that disappears.

Production build 0.71.5 2024