- Issue created by @phenaproxima
- First commit to issue fork.
- Merge request !647Issue #3494506:Skip package manager validation of using the local recipes → (Merged) created by shalini_jha
- 🇮🇳India shalini_jha
I have attempted to add a check to skip the Package Manager install readiness checks specifically for recipes. However, I am unsure if this is causing the Nightwatch failure
- 🇮🇳India shalini_jha
I believe this failure is not related to the changes I made. I am moving this for review. Please take a look and let me know if this aligns with the expectations of the ticket or if any updates are required.
- 🇺🇸United States phenaproxima Massachusetts
The Nightwatch failures are preexisting; not your fault.
I think that doing a skip if the source is
recipes
is a completely legitimate workaround.I kind of wonder, though, if it would be super hard to move the install readiness checks to
\Drupal\project_browser\Controller\InstallerController::begin()
. Because that is the only time Package Manager will ever be invoked. The only thing the Svelte app would need to know is whether Package Manager is present at all. It wouldn't have to care about the validation results or anything like that.Maybe we can try the deeper fix in another branch of this issue fork, and then commit the quick fix if it turns out to be a bugaboo? Or, hell, we could commit the quick fix but keep this issue open and work on the deeper fix in another branch.
In either case, though, this branch needs to be synced against 2.0.x HEAD due to merge conflicts. :(
- 🇮🇳India shalini_jha
@phenaproxima Thank you for the review & feedback. i am fixing this conflict issue till then.
- 🇮🇳India shalini_jha
Fixed merge conflict , as mentioned in #6 not moving this ticket.
- First commit to issue fork.
- 🇮🇳India narendraR Jaipur, India
Re #6, The problem with moving the install readiness checks to
\Drupal\project_browser\Controller\InstallerController::begin()
is:- The user will not know beforehand if there are errors or warnings on the page.
sveltejs/src/Project/ActionButton.svelte
uses this value to work/display the button based on errors or warnings.
- 🇺🇸United States phenaproxima Massachusetts
Thanks for looking into that, @narendrar. If that's the case, let's proceed with the quick-fix for now but open a follow-up (linked in a comment above the fix) to improve this.
- 🇺🇸United States phenaproxima Massachusetts
A fine workaround, in my opinion; ship it.
- First commit to issue fork.
-
chrisfromredfin →
committed ea54f920 on 2.0.x authored by
shalini_jha →
Issue #3494506 by shalini_jha, narendrar, chrisfromredfin, phenaproxima...
-
chrisfromredfin →
committed ea54f920 on 2.0.x authored by
shalini_jha →
- 🇺🇸United States chrisfromredfin Portland, Maine
Thanks Naren for bringing up those points, which are important. So, this is a good workaround for now in order to get Drupal CMS out the door.
Automatically closed - issue fixed for 2 weeks with no activity.