- Issue created by @Liam Morland
- 🇬🇧United Kingdom scott_euser
Should it also be a conflict in the composer.json perhaps to prevent it altogether? Or too far?
- 🇬🇧United Kingdom scott_euser
What's your suggestion for doc updates? At the moment the 3x to 4x upgrade section on the module homepage specifies cke5 a couple times.
I don't have the capacity to support cke4 myself (it's very different, has minimal test coverage, and tends to rely on a bunch of patches) so there isn't really an option to stay on cke4 as it stands unless you stay on older versions of Drupal Core.
Happy to make things more explicit + put more documentation elsewhere if you have ideas
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
If this restriction can be done in Composer, that would be great, but I'm not sure it can be.
I suggest adding to the top of "Upgrading from 3.x" in bold something like "Footnotes 4.x works with CKEditor 5, but not any older versions of CKEditor. For CKEditor 4, use Footnotes 3.1.x."
You could leave 3.1.x branch marked as supported and include on the project page that it will only receive security fixes. The fixes would probably be the same as 4.x anyway.
- 🇬🇧United Kingdom scott_euser
Thanks!
Okay I have updated the homepage. I moved it to the end of the section instead as I believe the most common use of reading that text is for the average user who would be wanting to use the latest of all things rather than selectively upgrading Footnotes but not Drupal Core nor CKE (which was EOL June 2023 and must use a paid long term support plan).
I don't intend to do any updates to 3.1.x, so I have removed (or not added) that as well sorry. Unless someone comes forward to maintain that, I think it needs to stay that way - I don't want to give false hopes there.
Yes adding a 'conflict' section won't help because I can't retrospectively add it to any previous releases, so it'll just mean that composer suggests an older 4x version rather than latest 4x. I think instead we can add a hook requirements fail so if someone has CKE4 installed that it gives a warning.
Updated the issue summary to reflect the state of things now.
- 🇬🇧United Kingdom scott_euser
Will mark as needs work since its partially done (ie, homepage update)