Add a note to the 5.0.0-rc2 release that css should be changed from sidr[aria-hidden=false] to sidr:not([hidden="hidden"])

Created on 13 December 2024, 4 months ago

Problem/Motivation

Upon upgrading from 5.0.0-rc1 to 5.0.0-rc2, my menu stopped working, and I traced it back to Closed sidr should be display: none when aria-hidden (keyboard support) Needs review .

CSS like this:

sidr[aria-hidden="false"]

no longer applies, and should be changed to

sidr:not([hidden="hidden"])

Proposed resolution

In the release notes of https://www.drupal.org/project/sidr/releases/5.0.0-rc2 , it might be useful to note that the markup has this change and that if certain sites use css such as sidr[aria-hidden="false"], that should be changed to sidr:not([hidden="hidden"])

Feature request
Status

Active

Version

5.0

Component

Documentation

Created by

🇨🇦Canada alberto56

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024