Closed sidr should be display: none when aria-hidden (keyboard support)

why was this not picked up ?

Sorry, I ran out of time. I'll do my best to take a look this weekend.

ok, I will check now version 5.0 because I have trouble with it - sidr-inner stays on display: none.

maybe I'll add a patch if I can fix it.

new patch for v. 5.0 RC1

Thanks for reporting this issue. I noticed that there were some anomalies in the JS related to the once() usage. I have fixed those. Additionally, I've made it such that when a Sidr closes, if the focus is still inside the Sidr panel, then the focus is sent back to the last used Sidr trigger.

As for the aria-hidden, I realized that when the Sidr panel is closed, it shouldn't be visible on the browser nor for assistive technologies. Hence, I've used hidden="hidden" to hide them away for good. For reference, here's a difference between hidden and aria-hidden.

As for the other suggestion, however, I believe it is time for this module to be replaced with some other module. I am looking for a project that would replace this Sidr module 💬 Deprecate the Sidr module in favor of another project Needs work .

Automatically closed - issue fixed for 2 weeks with no activity.

When I upgraded from 5.0.0-rc1 to 5.0.0-rc2, my menu stopped working entirely and I traced it back to this issue.

I documented a fix at ✨ Add a note to the 5.0.0-rc2 release that css should be changed from sidr[aria-hidden=false] to sidr:not([hidden="hidden"]) Active in case anyone else has the same problem

It turns out the project I am working on has 4 years of quite complex legacy code (CSS, SASS, JS), which targets hidden in a very specific way and which I cannot get to work with this change. I have found that by reverting the part of this patch which uses hidden="hidden" intead if aria-hidden="true", and by making it use aria-hidden instead of the hidden parameter, my legacy code works once again. If anyone is in the same situation as me, here is a patch which reverts only the part of this change which replaces aria-hidden with hidden.

I am not recommending you use this patch unless you are in that very specific situation.