Submit all N translation jobs with the same settings breaks suggestions

Created on 12 December 2024, 6 days ago

Problem/Motivation

Suggestions are selected and added on a per job basis. Marking disabled the Submit all N translation jobs with the same settings breaks the addition of suggestions for 2nd and successive jobs. Disable this option disable option. It isn't really needed.

Steps to reproduce

Select an item to be translated that has suggestions and it to cart.
Select multiple languages.
Select multiple suggestions for the first language.
Suggestions are only added to the first language/job.

Proposed resolution

Remove the disablement of "Submit all N translation jobs with the same settings".

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

9.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @heddn
  • Merge request !32Remove disablement → (Merged) created by heddn
  • Pipeline finished with Success
    6 days ago
    Total: 2206s
    #367090
  • Hi.

    It isn't really needed.

    This was done intentionally because Smartling has own concept of Jobs - something that includes files. So, when you select to submit content to multiple languages it means that multiple TMGMT Jobs (files) will be created (1 file per language) and all that files must be added to the newly created or existing Smartling job. That's why we decided to check this `Submit all N translation jobs with the same settings` option by default - we want all the files to be submitted to the one Smartling job.

    But now that you mention suggestions, I would probably agree that it makes sense not to check by default but to let users add suggested TMGMT Job items if they exist for 2nd and next TMGMT Jobs in a queue.

    But this issue applies to TMGMT itself, it needs to provide some UI where users can add all suggestions for needed TMGMT Jobs and only then submit them. Now it's a tradeoff between clicking through TMGMT Jobs queue and clicking once but without suggestions.

    Will merge soon.

Production build 0.71.5 2024