Placing a block containing a form in navigation layout prevents layout builder from saving

godotislate → closed merge request !10540

Put up MR 10539, which is ready for review. I'm not sure what's going on with the add tests, since the test-only job passes when it shouldn't. So I also pushed up a Test-only MR, which was failing in the wrong place. Meanwhile the test was consistently failing/passing as expected locally.

Thank you for noticing this and trying to help Navigation to be more stable. :)

Tested the MR code locally and fixes the issue with the form save process.

While testing it manually, noticed that a new blue rectangle appears on the Navigation Blocks page. See screenshot:

I think it could be easily removed using CSS, but wanted to flag it, just in case it could be an indicator of a possible issue.

While testing it manually, noticed that a new blue rectangle appears on the Navigation Blocks page.

Oh, interesting. With the LB element moved outside the form, I assume it's picked up some sort of border CSS rule. Will investigate.

Added a class to the layout builder element and updated the CSS selector to hide the border.

Not sure what's going on with the test. I think there might be some difference between my local env and Gitlab CI for browser-based tests. I'll look into that later when I have to time to revisit.

godotislate → reopened merge request !10540

godotislate → changed the visibility of the branch 3493671-test-only to hidden.

Created separate issue about strange behavior with the browser based tests not running as expected: 🐛 Functional Javascript test false postive and missing browser output Active

Refactored so that an event subscriber isn't necessary. #pre_render and #post_render callbacks can handle it. Tests pass, but still not getting the test only build to fail as expected in CI, though.

Thank you for pushing this one!

Tested the feature branch manually after the refactor and it is working as expected, solving the reported bug for Navigation & Layout Builder integration. Also tested manually in an entity form and no regressions were noticed.

Added a minor comment in the MR.

Regarding the test only build, not sure if we could go ahead with this one, or some extra work might be needed.

Thanks for the review, @plopesc. I made the suggested change as well as a similar one I forgot.

Not sure what's going on with the test. I created 🐛 Functional Javascript test false postive and missing browser output Active , because I have observed some unexpected behavior going on with the browser-based tests at least, but I've made little headway in identifying the cause. Postponing this issue on the resolving the tests.

Tried re-running the test-only job, and it failed as expected! https://git.drupalcode.org/issue/drupal-3493671/-/jobs/3825109.

I'm not sure what's differe, but unpostponing and putting back to NR.

Did a bit of docblock clean up. Test only fails correctly still, so this is ready.

godotislate → closed merge request !10540

Ok this was a doozy to test.

I pulled down 11.x and created a custom module with the block_alter and confirmed the issue occurs, checked this branch out and confirmed it is fixed.

Read through the code a few times, looks good once the two comments are addressed.

Comments were addressed, looks great!

After reading the issue and MR, I didn't find any unanswered questions. I updated credit.

godotislate → reopened merge request !10540

godotislate → closed merge request !10540

This looks like a really nice clean-up, didn't expect a negative diffstat from the issue title.

Committed/pushed to 11.x, thanks!

catch → closed merge request !10539

Automatically closed - issue fixed for 2 weeks with no activity.