- Issue created by @jurgenhaas
- Merge request !56Issue #3493540 by jurgenhaas: Only add Klaro libraries when at least one relevant app is enabled β (Merged) created by jurgenhaas
- π©πͺGermany jurgenhaas Gottmadingen
Seems pretty straightforward. Maybe it should be made configurable, I'm not sure.
- π¬π§United Kingdom catch
Manually tested by applying the MR diff against a stock Drupal CMS install. I then disabled the youtube and vimeo apps via the config page.
When logged out, only 5.6kb of JavaScript (compressed) instead of over 70kb compressed.
The footer link still shows up and now doesn't go anywhere, but I assume that's a separate issue?
- π¬π§United Kingdom catch
This makes sense to me and I don't really see a good case for configuration - can already configure which apps are enabled. Moving to RTBC.
- π©πͺGermany jurgenhaas Gottmadingen
The footer link still shows up and now doesn't go anywhere, but I assume that's a separate issue?
For new installations, the recipe got updated so that the menu link would be disabled when importing it as a new content entity. For testing this in an existing Drupal CMS installation you would have to manually disable not only the Klaro apps but also that menu link.
- π©πͺGermany jan kellermann
jan kellermann β made their first commit to this issueβs fork.
- π©πͺGermany jan kellermann
Thank you for the solution and the merge request.
I fixed small things and merged.In general there is a problem with caching but I will open a new issue for this.
-
jan kellermann β
committed 197e5318 on 3.x authored by
jurgenhaas β
Issue #3493540 by jurgenhaas: Only add Klaro libraries when at least one...
-
jan kellermann β
committed 197e5318 on 3.x authored by
jurgenhaas β