- Issue created by @catch
- π¬π§United Kingdom jonathan1055
Modules are still testing against 11.0.0 by default
Actually the default is 11.0.9 currently. We switched to using stable releases for the default, as there were a couple of incidents when the 11.x-dev branch had faults which broke Contrib testing. Sticking to stable releases mitigated against this, but we keep it up to date with the latest release.
Projects that are using
OPT_IN_TEST_NEXT_MINOR
will have been using 11.1.x-dev, so that has already been available for those maintainers who want to look ahead.I expect that as soon as 11.1.0 is released then the plan would be to make that the default 'current' core version to test against. But @fjgarlin woud make that call, as to the actual timing of when a new gitlab_templates release is made.
- π¬π§United Kingdom alexpott πͺπΊπ
@jonathan1055 I agree we shouldn't be testing 11.x by default but we should update to 11.x.0-beta as soon as it is available as this surfaces problems with a release once we've made a commitment to the API. Not doing this makes it more likely that real sites break.
- π¬π§United Kingdom jonathan1055
we should update to 11.x.0-beta as soon as it is available
OK that might be reasonable (probably). So we'd set
CORE_STABLE: '11.x.0-beta'
It will be interesting to see if our automatic detection of new releases flags this when it happens. The daily "check versions" job alerts us to new stable releases.
- First commit to issue fork.
- πΊπΈUnited States hestenet Portland, OR πΊπΈ
Made a provisional MR for the change - which currently fails check-versions, but I guess we see after this release happens and other things are branched: https://git.drupalcode.org/issue/gitlab_templates-3493016/-/pipelines/36...
- πͺπΈSpain fjgarlin
I created the MR from the above commits from @hestenet. As of right now 11.1.0 is still not released. Also, 11.2.x is not created yet and it might take a bit to be created.
We'll also need to update
scripts/check-versions.php
with the new tags. But pipelines aren't failing yet, so I'd just wait as the failed pipeline will suggest what to change.Setting to NW based on those things.
- π¬π§United Kingdom catch
11.x is currently the same as 11.2.x and we'll branch off that - 'next minor' should point to 11.x until 11.2.x is available, which won't be for months.
- πͺπΈSpain fjgarlin
Ready for review.
Downstream pipelines: https://git.drupalcode.org/project/gitlab_templates/-/pipelines/370922
- π¬π§United Kingdom jonathan1055
Good to see that the existing 'check versions' job alerts us.
https://git.drupalcode.org/issue/gitlab_templates-3397162/-/jobs/3725178
The message saysGathering releases from https://updates.drupal.org/release-history/drupal/current: - [ERROR] Drupal 11.1.0 is out! - [ERROR] The value of NEXT_MINOR_STABLE is currently 11.1.0 - this needs to be updated.
-
fjgarlin β
committed ce82e816 on main
Issue #3493016 by fjgarlin, hestenet, catch, jonathan1055, alexpott:...
-
fjgarlin β
committed ce82e816 on main
-
fjgarlin β
committed 8102cf62 on main
Issue #3493016 by fjgarlin, hestenet, catch, jonathan1055, alexpott:...
-
fjgarlin β
committed 8102cf62 on main
- π¬π§United Kingdom jonathan1055
It is interesting that this required the change of
CORE_NEXT_MINOR
from11.1.x-dev
back to the11.x-dev
. The expected value is11.2.x-dev
but 11.2.x dev does not exist yet. The script also allows forCORE_NEXT_MINOR
to be blank, so would that be a better option until 11.2.x-dev exists? We had problems using 11.x-dev as the 'next minor' last time, as there were unexpected differences between this and the eventual 11.0 release. Maybe if would be OK to not have anyCORE_NEXT_MINOR
for the short while that we wait for11.2.x-dev
? - πͺπΈSpain fjgarlin
From #10
11.2.x is available, which won't be for months.
The moment that 11.2.x is created, we will get an alert, and 11.2.x will be branched from 11.x when it happens, so I think it is ok like this in the interim.
- π¬π§United Kingdom jonathan1055
Sorry, I did not read #10 properly. In that case, yes we can leave it as is. I just remember having some surprises when using 11.x before.
- πͺπΈSpain fjgarlin
Not a problem. Yup, once 11.2.x is out we should swap to that one.