[2.0.0-rc1] Empty slot values when not renderable

christian.wiedemann → made their first commit to this issue’s fork.

Hi, yes getVisibleChildren is wrong because it does not unset the element if it is empty. I optimzed the check and I also add a Unit tests for differnt cases. Have a look, not sure if I match all cases. I also go one level deeper for the check if the children are array as well.

You have a cspell issue:

Unknown word (preproces) -- plain_text' => '', '#preproces' => 'dummy'], FALSE

Instead of isset($slot[$key]) && $slot[$key] == '', it may be better to do isset($slot[$key]) && is_string($slot[$key]) empty(trim($slot[$key]))). what do you think?

I also add a Unit tests for different cases. Have a look, not sure if I match all cases.

Thanks, can you also add a test with #cache?

I add more tests. Any more in mind? I removed the isset because isset is FALSE if '#markup' => NULL. I think we should not check for strings because empty works also with empty Markup objects.

 foreach (['#markup', '#plain_text'] as $key) {
      if (array_key_exists($key, $slot) && empty($slot[$key])) {
        unset($slot[$key]);
      }
    }

Automatically closed - issue fixed for 2 weeks with no activity.