Allow non-DDEV users to use the ngrok_url setting

Created on 9 December 2024, 13 days ago

Problem/Motivation

I use Laravel Valet as local development environment and I want to use Ngrok to test PDF generation locally. Valet even has a command, valet share, to easily set up Ngrok. It looks like in code there's a check if the user is using DDEV before the ngrok_url setting is considered, so I can't use it.

Proposed resolution

Use the ngrok_url setting if it's present, regardless of the local development environment the user is using. This setting should be set in local.settings.php to make sure it doesn't end up in production.

✨ Feature request

Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.

Merge Requests

!16Allow non-DDEV users to use the ngrok_url setting
Merged
🇧🇪Belgium dieterholvoet
updated 12 days ago

Comments & Activities

Issue created by @dieterholvoet
Merge request !16Allow non-DDEV users to use the ngrok_url setting → (Merged) created by dieterholvoet
Comment 13 days ago →
🇧🇪Belgium dieterholvoet Brussels
Pipeline finished with Success
13 days ago
Total: 147s
#363567
First commit to issue fork.
Pipeline finished with Skipped
12 days ago
#364021
Comment 12 days ago →
🇬🇧United Kingdom scott_euser
The str_contains closing bracket was in the wrong spot, but otherwise LGTM thanks!
Comment 12 days ago →
System Message

scott_euser → committed be7b2c6b on 1.0.x authored by dieterholvoet →
Issue #3492689 by dieterholvoet, scott_euser: Allow non-DDEV users to...

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Allow non-DDEV users to use the ngrok_url setting

Problem/Motivation

Proposed resolution

Merge Requests

!16Allow non-DDEV users to use the ngrok_url settingMerged

Comments & Activities

!16Allow non-DDEV users to use the ngrok_url setting
Merged