Coding standards issue

Hi, I made a merge request to fix the coding standards issue in this module, I hope it can be reviewed soon.

Hi
I reviewed the MR and the PHPCS errors have been fixed
The phpcs pipeline is now passing
Moving it to RTBC

Thanks @akulsaxena but I still see a bunch of CSPELL, ESLINT, PHPSTAN and STYLEINT errors, do you have some time to fix them? I might have a look on these today maybe.

Hello @danrod,

This issue has been dedicated to addressing coding standard fixes, and since the PHPCS pipeline is now passing, I have moved it to RTBC.

Regarding the CSPELL, ESLINT, PHPSTAN, and STYLEINT errors, wouldn't it be more efficient to create a separate issue to track the requested fixes, with the relevant changes outlined in the issue summary?

Thank you for your attention to this matter.

ok @akulsaxena, that makes sense, I'll test this MR and if it goes ok, I'll merge it to the 2.0.x branch and create another issue for the CSPELL, ESLINT, PHPSTAN, and STYLEINT errors

Was this MR tested at all? I ran into a WSOD when testing this MR:

The website encountered an unexpected error. Try again later.

TypeError: Drupal\Core\Form\ConfigFormBase::__construct(): Argument #2 ($typedConfigManager) must be of type Drupal\Core\Config\TypedConfigManagerInterface, Drupal\Core\Entity\EntityTypeManager given, called in /var/www/html/web/modules/contrib/gifplayer/src/Form/SettingsForm.php on line 36 in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).
Drupal\gifplayer\Form\SettingsForm->__construct() (Line: 45)
Drupal\gifplayer\Form\SettingsForm::create() (Line: 36)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition() (Line: 48)
Drupal\Core\Controller\HtmlFormController->getFormObject() (Line: 58)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I'll change this to "Needs Work" and try to fix these issues myself.

Merged some changes for some urgent fixes ( https://www.drupal.org/project/gifplayer/issues/3501958 🐛 Latest module doesn't work at all in D11 and D10.3/D10.4 Active ) in the branch 2.0.x, then merged that branch to this MR and of course this is just broke as hell.

I'd appreciate not to commit any changes on this MR until I figure it out what's going on, thanks,

Thanks to everyone involved, I skipped ESLINT because it was giving me a lot headaches and we need to have a tagged release as soon as possible, I'm going to merge the MR https://git.drupalcode.org/project/gifplayer/-/merge_requests/5 and close this to "Fixed" today.

New Release with the fixes here: https://www.drupal.org/project/gifplayer/releases/2.0.3 →

I'll create another issue for the lint fixes.

Thanks to everyone involved

Automatically closed - issue fixed for 2 weeks with no activity.