Contrib.social

Incorrect use of 'render element' for webform_submission_data

Open on Drupal.org →
Created on 6 December 2024, 16 days ago

Problem/Motivation

Coming from 🐛 Can only intentionally re-render an entity with references 20 times Needs work .

It seems webform_submission_data theme hook uses 'render element' => 'elements' and webform-submission-data.html.twig prints {{ elements }} directly which technically works.
But when combined with 🐛 Can only intentionally re-render an entity with references 20 times Needs work it triggers the recursion protection a second time.

Steps to reproduce

TODO

Proposed resolution

Looking at how core uses render element, and the documentation for it in theme.api.php, it looks like an improper use and we should instead collect all renderable children elements in a variable (e.g.: content) and print that instead in the template.

Remaining tasks

?

User interface changes

none

API changes

?

Data model changes

none

🐛 Bug report
Status

Active

Version

6.3

Component

Code

Created by

🇧🇪Belgium herved

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024